IlyaSobolev/DocSpace-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Client: move portal settings roout layoyt to lazy loading from react-router-dom

Browse Source
This commit is contained in:
Timofey Boyko 2024-06-20 10:17:09 +03:00
parent b7050a86e2
commit 5135fd31a3
3 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/client/src/pages/PortalSettings/index.js
View File

@ -27,11 +27,13 @@
import React from "react"; import React from "react";
import { Outlet, useLocation } from "react-router-dom"; import { Outlet, useLocation } from "react-router-dom";
import Layout from "./Layout";
import Panels from "SRC_DIR/components/FilesPanels"; import Panels from "SRC_DIR/components/FilesPanels";
import PrivateRoute from "SRC_DIR/components/PrivateRouteWrapper";
import ErrorBoundary from "SRC_DIR/components/ErrorBoundaryWrapper";
import { generalRoutes } from "SRC_DIR/routes/general"; import { generalRoutes } from "SRC_DIR/routes/general";
import Layout from "./Layout";
const Settings = () => { const Settings = () => {
const location = useLocation(); const location = useLocation();
@ -58,4 +60,12 @@ const Settings = () => {
); );
}; };
export default Settings; export const Component = () => {
return (
<PrivateRoute restricted>
<ErrorBoundary>
<Settings />
</ErrorBoundary>
</PrivateRoute>
);
};

8
packages/client/src/routes/index.js
View File

@ -27,13 +27,7 @@
import PortalSettingsRoutes from "./portalSettings"; import PortalSettingsRoutes from "./portalSettings";
import ClientRoutes from "./client"; import ClientRoutes from "./client";
import ConfirmRoutes from "./confirm"; import ConfirmRoutes from "./confirm";
import { generalRoutes } from "./general";
const routes = [ const routes = [...ClientRoutes, PortalSettingsRoutes, ...ConfirmRoutes];
...ClientRoutes,
PortalSettingsRoutes,
...ConfirmRoutes,
// ...generalRoutes,
];
export default routes; export default routes;

16
packages/client/src/routes/portalSettings.js
View File

@ -24,24 +24,16 @@
// content are licensed under the terms of the Creative Commons Attribution-ShareAlike 4.0 // content are licensed under the terms of the Creative Commons Attribution-ShareAlike 4.0
// International. See the License terms at http://creativecommons.org/licenses/by-sa/4.0/legalcode // International. See the License terms at http://creativecommons.org/licenses/by-sa/4.0/legalcode
import React from "react";
import { Navigate } from "react-router-dom"; import { Navigate } from "react-router-dom";
import loadable from "@loadable/component"; import loadable from "@loadable/component";
import Error404 from "@docspace/shared/components/errors/Error404"; import Error404 from "@docspace/shared/components/errors/Error404";
import componentLoader from "@docspace/shared/utils/component-loader"; import componentLoader from "@docspace/shared/utils/component-loader";
import PrivateRoute from "../components/PrivateRouteWrapper";
import ErrorBoundary from "../components/ErrorBoundaryWrapper";
import { generalRoutes } from "./general"; import { generalRoutes } from "./general";
import SettingsContainer from "../pages/PortalSettings/categories/integration/LDAP/sub-components/SettingsContainer"; import SettingsContainer from "../pages/PortalSettings/categories/integration/LDAP/sub-components/SettingsContainer";
import SyncContainer from "../pages/PortalSettings/categories/integration/LDAP/sub-components/SyncContainer"; import SyncContainer from "../pages/PortalSettings/categories/integration/LDAP/sub-components/SyncContainer";
const PortalSettings = loadable(() =>
componentLoader(() => import("../pages/PortalSettings")),
);
const CustomizationSettings = loadable(() => const CustomizationSettings = loadable(() =>
componentLoader( componentLoader(
() => import("../pages/PortalSettings/categories/common/index.js"), () => import("../pages/PortalSettings/categories/common/index.js"),
@ -358,13 +350,7 @@ const Viewer = loadable(() =>
const PortalSettingsRoutes = { const PortalSettingsRoutes = {
path: "portal-settings/", path: "portal-settings/",
element: ( lazy: () => import("../pages/PortalSettings"),
<PrivateRoute restricted>
<ErrorBoundary>
<PortalSettings />
</ErrorBoundary>
</PrivateRoute>
),
errorElement: <Error404 />, errorElement: <Error404 />,
children: [ children: [
{ {