From 05d5fc7bef564092ebe4a81c47cad6204a95bd38 Mon Sep 17 00:00:00 2001 From: Elyor Djalilov Date: Fri, 19 Jul 2024 19:16:41 +0500 Subject: [PATCH 1/5] Fix Bug 69276 - Rooms: Info: History. When Revoke link the default link in the story, an empty action without description is displayed. --- packages/client/public/locales/en/InfoPanel.json | 1 + .../Home/InfoPanel/Body/views/History/FeedInfo.ts | 8 +++++++- .../Body/views/History/useFeedTranslation.tsx | 14 +++++++++++++- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/packages/client/public/locales/en/InfoPanel.json b/packages/client/public/locales/en/InfoPanel.json index a1b5692fa8..dbe0e2891e 100644 --- a/packages/client/public/locales/en/InfoPanel.json +++ b/packages/client/public/locales/en/InfoPanel.json @@ -40,6 +40,7 @@ "RoomExternalLinkCreated": "Link created.", "RoomExternalLinkDeleted": "Link <1>«{{linkTitle}}» deleted.", "RoomExternalLinkRenamed": "Link <1>«{{oldLinkTitle}}» renamed to <1>«{{linkTitle}}»", + "RoomExternalLinkRevoked": "Previous link <1>«{{linkTitle}}» revoked
New Link <1>«{{linkTitle}}» created", "RoomGroupAdded": "Groups added.", "RoomGroupRemove": "Group removed", "RoomLogoCreated": "Icon changed", diff --git a/packages/client/src/pages/Home/InfoPanel/Body/views/History/FeedInfo.ts b/packages/client/src/pages/Home/InfoPanel/Body/views/History/FeedInfo.ts index 5324a0ca00..79533b08ff 100644 --- a/packages/client/src/pages/Home/InfoPanel/Body/views/History/FeedInfo.ts +++ b/packages/client/src/pages/Home/InfoPanel/Body/views/History/FeedInfo.ts @@ -7,6 +7,7 @@ enum FeedAction { Rename = "rename", Move = "move", Copy = "copy", + Revoke = "revoke", } enum FeedTarget { @@ -148,10 +149,15 @@ export const feedInfo = [ actionType: `${FeedAction.Rename}`, }, { - key: "RoomExternalLinkRevoked", + key: "RoomExternalLinkDeleted", targetType: `${FeedTarget.RoomExternalLink}`, actionType: `${FeedAction.Delete}`, }, + { + key: "RoomExternalLinkRevoked", + targetType: `${FeedTarget.RoomExternalLink}`, + actionType: `${FeedAction.Revoke}`, + }, // // USER { diff --git a/packages/client/src/pages/Home/InfoPanel/Body/views/History/useFeedTranslation.tsx b/packages/client/src/pages/Home/InfoPanel/Body/views/History/useFeedTranslation.tsx index 6ce3c834fe..76d2943e4f 100644 --- a/packages/client/src/pages/Home/InfoPanel/Body/views/History/useFeedTranslation.tsx +++ b/packages/client/src/pages/Home/InfoPanel/Body/views/History/useFeedTranslation.tsx @@ -89,7 +89,7 @@ export const useFeedTranslation = ( components={{ 1: }} /> ); - case "RoomExternalLinkRevoked": + case "RoomExternalLinkDeleted": return ( }} /> ); + case "RoomExternalLinkRevoked": + return ( + }} + /> + ); case "RoomCreateUser": return t("InfoPanel:RoomCreateUser"); case "RoomUpdateAccessForUser": From fcb6d9dba277aed0e4fafbcf9cf32c30a9ab63d7 Mon Sep 17 00:00:00 2001 From: Alexey Safronov Date: Fri, 19 Jul 2024 18:17:04 +0400 Subject: [PATCH 2/5] Whitelabel: ban empty logoTextWhiteLabel --- .../categories/common/Branding/whitelabel.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/packages/client/src/pages/PortalSettings/categories/common/Branding/whitelabel.js b/packages/client/src/pages/PortalSettings/categories/common/Branding/whitelabel.js index ce16de94cd..ce2c009ddb 100644 --- a/packages/client/src/pages/PortalSettings/categories/common/Branding/whitelabel.js +++ b/packages/client/src/pages/PortalSettings/categories/common/Branding/whitelabel.js @@ -82,6 +82,7 @@ const WhiteLabel = (props) => { const [logoTextWhiteLabel, setLogoTextWhiteLabel] = useState(""); const [isSaving, setIsSaving] = useState(false); + const [isEmpty, setIsEmpty] = useState(!logoText); const isMobileView = deviceType === DeviceType.mobile; @@ -122,6 +123,12 @@ const WhiteLabel = (props) => { navigate(url); }; + useEffect(() => { + if (!isWhitelableLoaded) return; + + setIsEmpty(!logoText); + }, [logoText]); + useEffect(() => { const companyNameFromSessionStorage = getFromSessionStorage("companyName"); @@ -144,12 +151,18 @@ const WhiteLabel = (props) => { const onChangeCompanyName = (e) => { const value = e.target.value; + setIsEmpty(!value || value?.trim() === ""); setLogoTextWhiteLabel(value); saveToSessionStorage("companyName", value); }; const onUseTextAsLogo = () => { + if (!logoTextWhiteLabel) { + return; + } + let newLogos = logoUrlsWhiteLabel; + for (let i = 0; i < logoUrlsWhiteLabel.length; i++) { const options = getLogoOptions( i, @@ -303,6 +316,7 @@ const WhiteLabel = (props) => { labelText={t("Common:CompanyName")} isVertical={true} className="settings_unavailable" + hasError={isEmpty} > { isAutoFocussed={!isMobile} tabIndex={1} maxLength={30} + hasError={isEmpty} />