Doceditor: delete useless API requests

packages/doceditor/src/components/Editor.tsx

@@ -51,7 +51,6 @@ import {
 } from "@/utils/events";
 import useInit from "@/hooks/useInit";
 import useEditorEvents from "@/hooks/useEditorEvents";
-import useFilesSettings from "@/hooks/useFilesSettings";
 
 type IConfigType = IConfig & {
   events?: {
@@ -77,6 +76,8 @@ const Editor = ({
   errorMessage,
   isSkipError,
 
+  filesSettings,
+
   onDownloadAs,
   onSDKRequestSharingSettings,
   onSDKRequestSaveAs,
@@ -89,7 +90,6 @@ const Editor = ({
   const { t, i18n } = useTranslation(["Common", "Editor", "DeepLink"]);
 
   const searchParams = useSearchParams();
-  const { filesSettings } = useFilesSettings({});
 
   const openOnNewPage = IS_ZOOM ? false : !filesSettings?.openEditorInSameTab;
 

packages/doceditor/src/components/Root.tsx

@@ -231,6 +231,7 @@ const Root = ({
           errorMessage={error?.message}
           isSkipError={!!isSkipError}
           onDownloadAs={onDownloadAs}
+          filesSettings={filesSettings}
           onSDKRequestSharingSettings={onSDKRequestSharingSettings}
           onSDKRequestSaveAs={onSDKRequestSaveAs}
           onSDKRequestInsertImage={onSDKRequestInsertImage}

packages/doceditor/src/hooks/useFilesSettings.ts

@@ -30,28 +30,21 @@ import { getSettingsFiles } from "@docspace/shared/api/files";
 import { TFilesSettings } from "@docspace/shared/api/files/types";
 
 const useFilesSettings = ({}) => {
-  const [settings, setSettings] = React.useState({} as TFilesSettings);
-
-  const requestRunning = React.useRef(false);
-
-  const initSettings = React.useCallback(async () => {
-    if (requestRunning.current) return;
-
-    requestRunning.current = true;
+  const [settings, setSettings] = React.useState<TFilesSettings>(
+    {} as TFilesSettings,
+  );
 
+  React.useEffect(() => {
+    const initSettings = async () => {
       const res = await getSettingsFiles();
 
       setSettings(res);
-    requestRunning.current = false;
-  }, []);
+    };
 
-  React.useEffect(() => {
-    if (settings.extsArchive) return;
     initSettings();
-  }, [initSettings, settings.extsArchive]);
+  }, []);
 
   return { filesSettings: settings };
 };
 
 export default useFilesSettings;
-

packages/doceditor/src/hooks/useTheme.ts

@@ -90,17 +90,17 @@ const useTheme = ({
   const isRequestRunning = React.useRef(false);
 
   const getCurrentColorTheme = React.useCallback(async () => {
-    if (isRequestRunning.current) return;
+    if (isRequestRunning.current || colorTheme) return;
     isRequestRunning.current = true;
     const colorThemes = await getAppearanceTheme();
 
-    const colorTheme = colorThemes.themes.find(
+    const curColorTheme = colorThemes.themes.find(
       (t) => t.id === colorThemes.selected,
     );
 
     isRequestRunning.current = false;
-    if (colorTheme) setCurrentColorTheme(colorTheme);
-  }, []);
+    if (curColorTheme) setCurrentColorTheme(curColorTheme);
+  }, [colorTheme]);
 
   const getUserTheme = React.useCallback(() => {
     const SYSTEM_THEME = getSystemTheme();

packages/doceditor/src/types/index.ts

@@ -229,6 +229,7 @@ export type EditorProps = {
   isSharingAccess?: boolean;
   errorMessage?: string;
   isSkipError?: boolean;
+  filesSettings: TFilesSettings;
 
   onDownloadAs?: (obj: object) => void;
   onSDKRequestSharingSettings?: () => void;